From 90a66f5a5db3a8dba9af891e48a981d9efd9cfa0 Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Wed, 26 Mar 2025 17:53:42 +0100 Subject: [PATCH] gui/macOS: Avoid crash from bad manager release Signed-off-by: Claudio Cambra --- src/gui/macOS/fileprovideritemmetadata_mac.mm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gui/macOS/fileprovideritemmetadata_mac.mm b/src/gui/macOS/fileprovideritemmetadata_mac.mm index 8ff39979f..9a4e00c89 100644 --- a/src/gui/macOS/fileprovideritemmetadata_mac.mm +++ b/src/gui/macOS/fileprovideritemmetadata_mac.mm @@ -122,7 +122,7 @@ QString FileProviderItemMetadata::getUserVisiblePath() const __block QString returnPath = QObject::tr("Unknown"); NSFileProviderManager *const manager = FileProviderUtils::managerForDomainIdentifier(domainId); - if (manager == nil) { + if (manager == nil) { qCWarning(lcMacImplFileProviderItemMetadata) << "Null manager, cannot get item path"; return returnPath; } @@ -147,8 +147,6 @@ QString FileProviderItemMetadata::getUserVisiblePath() const dispatch_semaphore_wait(semaphore, DISPATCH_TIME_FOREVER); dispatch_release(semaphore); - [manager release]; - return returnPath; } -- 2.30.2